public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] auparse.c events_are_equal() and event matching
Date: Tue, 02 Dec 2014 08:44:21 -0500	[thread overview]
Message-ID: <11077223.gLdkPNx1jM@x2> (raw)
In-Reply-To: <20141202025147.GD9526@madcap2.tricolour.ca>

On Monday, December 01, 2014 09:51:47 PM Richard Guy Briggs wrote:
> On 14/12/01, Steve Grubb wrote:
> > On Monday, November 24, 2014 08:23:26 PM Guillaume Destuynder wrote:
> > > on our RHEL6 machines, with kernel 2.6.32, we noticed that sometimes an
> > > audit message comes in but libaudit does not see it as the same event.
> > > 
> > > The milliseconds field of the timestamp differs (but the timestamp
> > > seconds and event serial are identical).
> > 
> > This seems to be a bug in the kernel code. Its a fundamental principle
> > that all records that make up an event have the same time stamp and serial
> > number.
>
> Is it?  I don't know if there is any value in serializing the parts that
> make up one event.

Yes it is. This is a day 1 design decision. The serial number is to 
differentiate events within the same millisecond. Its not to be an identifier 
that alone is used for serialization. Without this ordering, we cannot glue 
all the parts of the event back together because the kernel _itself_ does not 
serialize events. Events can come out intermingled.

The original design:
https://www.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.5-rc1/2.6.5-rc1-mm2/broken-out/lightweight-auditing-framework.patch

excerpt:
 The timestamp of the
 record and this serial number are used by the user-space daemon to
 determine which pieces belong to the same audit record.  The
 (timestamp,serial) tuple is unique for each syscall and is live from
 syscall entry to syscall exit.


-Steve

  reply	other threads:[~2014-12-02 13:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25  4:23 [PATCH] auparse.c events_are_equal() and event matching Guillaume Destuynder
2014-12-01 14:58 ` Steve Grubb
2014-12-02  2:51   ` Richard Guy Briggs
2014-12-02 13:44     ` Steve Grubb [this message]
2014-12-10  2:54 ` Richard Guy Briggs
2014-12-11  0:12   ` Guillaume Destuynder
2014-12-11 19:34     ` Richard Guy Briggs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11077223.gLdkPNx1jM@x2 \
    --to=sgrubb@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=rgb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox