From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B7CC433F5 for ; Wed, 15 Sep 2021 03:32:16 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 709DA6113E for ; Wed, 15 Sep 2021 03:32:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 709DA6113E Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631676734; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Jd6lOu47T23zoFdXb/HxoxbyRKCYFIyKwmRlKK6EJLw=; b=WrgXaQIBaXo4ooShFnqFzkNvGfl57MvDA/R6GOZe55JEq9oLq39t7Qh95gFp6O95/34EK0 ukMOqd14dj2ZjpKJnAvMsXEgLVErLDA+c8YZO0j/ZobY7DEHVMFAfTZb8D91r0j5sS5qYv wFxcD3ZgqTa/xDFJHg65HMOdeQ0QMu4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-Z6e84bwLNkCY9iAMj5waYw-1; Tue, 14 Sep 2021 23:32:13 -0400 X-MC-Unique: Z6e84bwLNkCY9iAMj5waYw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 88DFE1084686; Wed, 15 Sep 2021 03:32:09 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C8C8B60C81; Wed, 15 Sep 2021 03:32:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 64FD91803B30; Wed, 15 Sep 2021 03:32:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 18F3W5kl020906 for ; Tue, 14 Sep 2021 23:32:05 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8C6715C3DF; Wed, 15 Sep 2021 03:32:05 +0000 (UTC) Received: from x2.localnet (unknown [10.22.8.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 254385C25A; Wed, 15 Sep 2021 03:32:02 +0000 (UTC) From: Steve Grubb To: linux-audit@redhat.com, Enzo Matsumiya Subject: Re: [PATCH] auditd: fix missing space with enriched log format Date: Tue, 14 Sep 2021 23:32:00 -0400 Message-ID: <11826656.O9o76ZdvQC@x2> Organization: Red Hat In-Reply-To: <20210915015548.8515-1-ematsumiya@suse.de> References: <20210915015548.8515-1-ematsumiya@suse.de> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tuesday, September 14, 2021 9:55:48 PM EDT Enzo Matsumiya wrote: > When audit.log is opened with cat or less, for example, with log format > = ENRICHED, there's no space between data and the enriched part, only > AUDIT_INTERP_SEPARATOR (0x1d): This is by design. > type=USER_CMD msg=audit(1631669179.082:2403): ... res=success'UID="enzo" > AUID="unset" ^ (0x1d) > > sep_done should be checked if it's 1 as well, so a space is added before > the first enriched field. Why? Thanks, -Steve > Signed-off-by: Enzo Matsumiya > --- > src/auditd-event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/auditd-event.c b/src/auditd-event.c > index 788c44a08197..636553187279 100644 > --- a/src/auditd-event.c > +++ b/src/auditd-event.c > @@ -365,7 +365,7 @@ static int add_simple_field(auparse_state_t *au, size_t > len_left, int encode) > > // Setup pointer > ptr = &format_buf[FORMAT_BUF_LEN - len_left]; > - if (sep_done > 1) { > + if (sep_done >= 1) { > *ptr = ' '; > ptr++; > num = 1; -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit