From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Paris <eparis@redhat.com>
Subject: Re: [PATCH v2] [AUDIT] Add uid, gid fields to ANOM_PROMISCUOUS
	message
Date: Thu, 10 Jan 2008 15:05:53 -0500
Message-ID: <1199995553.30996.25.camel@localhost.localdomain>
References: <1199985923.7836.63.camel@klausk.br.ibm.com>
	<200801101241.00467.sgrubb@redhat.com>
	<1199987893.7836.66.camel@klausk.br.ibm.com>
	<200801101322.39958.sgrubb@redhat.com>
	<1199994269.17775.6.camel@klausk.br.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <1199994269.17775.6.camel@klausk.br.ibm.com>
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Klaus Heinrich Kiwi <klausk@linux.vnet.ibm.com>
Cc: "Linux-audit@redhat.com" <Linux-audit@redhat.com>
List-Id: linux-audit@redhat.com


On Thu, 2008-01-10 at 17:44 -0200, Klaus Heinrich Kiwi wrote:
> Changes the ANOM_PROMISCUOUS message to include uid and gid fields,
> making it consistent with other AUDIT_ANOM_ messages and in the
> format the userspace is expecting.

I'll fix up the fact that audit_get_loginuid() and friends now take a
task rather than an audit context and push it along.

Thanks.
-Eric

> 
> Signed-off-by: Klaus Heinrich Kiwi <klausk@br.ibm.com>
> ---
>  net/core/dev.c |   16 +++++++++-------
>  1 files changed, 9 insertions(+), 7 deletions(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 0848da3..73476be 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -2757,13 +2757,15 @@ static void __dev_set_promiscuity(struct net_device *dev, int inc)
>  		printk(KERN_INFO "device %s %s promiscuous mode\n",
>  		       dev->name, (dev->flags & IFF_PROMISC) ? "entered" :
>  							       "left");
> -		audit_log(current->audit_context, GFP_ATOMIC,
> -			AUDIT_ANOM_PROMISCUOUS,
> -			"dev=%s prom=%d old_prom=%d auid=%u ses=%u",
> -			dev->name, (dev->flags & IFF_PROMISC),
> -			(old_flags & IFF_PROMISC),
> -			audit_get_loginuid(current->audit_context),
> -			audit_get_sessionid(current->audit_context));
> +		if (audit_enabled)
> +			audit_log(current->audit_context, GFP_ATOMIC,
> +				AUDIT_ANOM_PROMISCUOUS,
> +				"dev=%s prom=%d old_prom=%d auid=%u uid=%u gid=%u ses=%u",
> +				dev->name, (dev->flags & IFF_PROMISC),
> +				(old_flags & IFF_PROMISC),
> +				audit_get_loginuid(current->audit_context),
> +				current->uid, current->gid,
> +				audit_get_sessionid(current->audit_context));
>  
>  		if (dev->change_rx_flags)
>  			dev->change_rx_flags(dev, IFF_PROMISC);
> -- 
> 1.5.3.7
> 
>