From: "Miloslav Trmač" <mitr@redhat.com>
To: Yu Zhiguo <yuzg@cn.fujitsu.com>
Cc: audit-list <linux-audit@redhat.com>
Subject: Re: [PATCH] make it match explicitly when use option '-a', '-A' and '-d' to specify "list,action"
Date: Fri, 18 Jul 2008 13:56:32 +0200 [thread overview]
Message-ID: <1216382192.2699.12.camel@amilo> (raw)
In-Reply-To: <488083FA.5080504@cn.fujitsu.com>
Hello,
Yu Zhiguo píše v Pá 18. 07. 2008 v 19:52 +0800:
> Miloslav Trmač wrote:
> >> I know "list" and "action" can be changed, this is convenient.
> > No, it is undocumented. As an author of system-config-audit I'd much
> > prefer if audit rejected such options, replicating the exact code in
> > auditctl in order to handle all undocumented behavior the same way as
> > auditctl is rather impractical.
>
> Indeed it is uncompatible with manpage, but it seems that Mr. Steve
> like this convenient method:
Oh. OK.
> >> - if (strstr(opt, "task"))
> >> + if (!strncmp(opt, "task,", p - opt + 1) || !strcmp(p, ",task"))
> >> *flags = AUDIT_FILTER_TASK;
> > Each string should be recognized only in the documented position IMHO.
> > The patch also replaces case-sensitive matching by case-insensitive,
> > which is not described above.
>
> Both strstr and strcmp are case-sensitive.
You're obviously right, I'm sorry. I wasn't paying enough attention.
Mirek
next prev parent reply other threads:[~2008-07-18 11:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 6:54 [PATCH] make it match explicitly when use option '-a', '-A' and '-d' to specify "list,action" Yu Zhiguo
2008-07-18 8:49 ` Miloslav Trmač
2008-07-18 11:52 ` Yu Zhiguo
2008-07-18 11:56 ` Miloslav Trmač [this message]
2008-07-30 6:32 ` Yu Zhiguo
2008-07-31 0:57 ` Yu Zhiguo
2008-08-04 19:37 ` Steve Grubb
2008-08-05 2:14 ` [PATCH] the usage of strchr is wrong Yu Zhiguo
2008-08-05 2:43 ` Yu Zhiguo
2008-08-05 12:00 ` Steve Grubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216382192.2699.12.camel@amilo \
--to=mitr@redhat.com \
--cc=linux-audit@redhat.com \
--cc=yuzg@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox