From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Paris <eparis@redhat.com>
Subject: Re: [PATCH -v2 4/4] AUDIT: emit new record type showing all capset
 information
Date: Thu, 06 Nov 2008 14:03:38 -0500
Message-ID: <1225998218.3300.171.camel@localhost.localdomain>
References: <20081103201742.12059.36030.stgit@paris.rdu.redhat.com>
	<20081103201759.12059.44897.stgit@paris.rdu.redhat.com>
	<20081104165540.GA25093@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <20081104165540.GA25093@us.ibm.com>
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, morgan@kernel.org, viro@ZenIV.linux.org.uk
List-Id: linux-audit@redhat.com

On Tue, 2008-11-04 at 10:55 -0600, Serge E. Hallyn wrote:
> Quoting Eric Paris (eparis@redhat.com):
> > diff --git a/kernel/capability.c b/kernel/capability.c
> > index 33e51e7..3d7fc70 100644
> > --- a/kernel/capability.c
> > +++ b/kernel/capability.c
> > @@ -7,6 +7,7 @@
> >   * 30 May 2002:	Cleanup, Robert M. Love <rml@tech9.net>
> >   */
> > 
> > +#include <linux/audit.h>
> >  #include <linux/capability.h>
> >  #include <linux/mm.h>
> >  #include <linux/module.h>
> > @@ -457,6 +458,8 @@ asmlinkage long sys_capset(cap_user_header_t header, const cap_user_data_t data)
> >  		i++;
> >  	}
> > 
> > +	audit_log_capset(pid, &effective, &inheritable, &permitted);
> 
> Shouldn't sys_capset() fail if audit_log_capset() returns -ENOMEM?

yes, I think it should, but look for the next e-mail.....