From mboxrd@z Thu Jan 1 00:00:00 1970 From: LC Bruzenak Subject: Re: [PATCH] Don't crash on unknown S_IFMT file modes Date: Fri, 27 Mar 2009 10:56:04 -0500 Message-ID: <1238169364.7013.256.camel@homeserver> References: <205213183.2433851238079924103.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> <1238168675.7013.254.camel@homeserver> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1238168675.7013.254.camel@homeserver> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Miloslav Trmac Cc: linux-audit List-Id: linux-audit@redhat.com On Fri, 2009-03-27 at 10:44 -0500, LC Bruzenak wrote: > Mirek, > > After applying this patch my build fails in the parse test section due > to a difference of no space after a comma: > > diff -u ../../auparse/test/auparse_test.ref auparse_test.cur > --- ../../auparse/test/auparse_test.ref 2009-02-24 15:11:35.000000000 > -0600 > +++ auparse_test.cur 2009-03-27 10:21:34.000000000 -0500 > ... > - mode=040730 (dir, 730) > + mode=040730 (dir,730) > > I have made some local changes myself but I don't think it is me (which > of course probably means it IS). > > Do you think your changes would cause this? > > Thx, > LCB. > This change fixed it for me - adding a space. You likely want to apply the same fix, or if you like this formatting, change the checked reference output. // and the read, write, execute flags in octal - asprintf(&out, "%s %03o", buf, (S_IRWXU|S_IRWXG|S_IRWXO) & ival); + asprintf(&out, "%s, %03o", buf, (S_IRWXU|S_IRWXG|S_IRWXO) & ival); -- LC (Lenny) Bruzenak lenny@magitekltd.com