From: LC Bruzenak <lenny@magitekltd.com>
To: Steve Grubb <sgrubb@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: performance questions
Date: Fri, 30 Sep 2011 09:20:43 -0500 [thread overview]
Message-ID: <1317392443.2038.19.camel@lcb> (raw)
In-Reply-To: <201109300920.01318.sgrubb@redhat.com>
On Fri, 2011-09-30 at 09:20 -0400, Steve Grubb wrote:
> On Thursday, September 29, 2011 11:33:09 AM LC Bruzenak wrote:
...
>
> You might try this:
...
>
> - _get_exename(exename, sizeof(exename));
> + if (exename[0] == 0)
> + _get_exename(exename, sizeof(exename));
> if (tty == NULL)
> tty = _get_tty(ttyname, TTY_PATH);
> else if (*tty == 0)
Well, we could (and then it would work like the others) but we really
want to store the exename I think. Isn't that what becomes
"exe=<EXEPATH>" in the event?
>
> We can probably use the return value of fprintf() +1 (for the NULL byte) and
> just keep the running total in memory.
Oh, right. That would be more precise. Good idea!
Since we're looking, what about the fstatfs in check_disk_space? Any
thoughts on that one?
Thanks Steve!
LCB
--
LC (Lenny) Bruzenak
lenny@magitekltd.com
next prev parent reply other threads:[~2011-09-30 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 15:33 performance questions LC Bruzenak
2011-09-30 13:20 ` Steve Grubb
2011-09-30 14:20 ` LC Bruzenak [this message]
2011-09-30 14:35 ` Steve Grubb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317392443.2038.19.camel@lcb \
--to=lenny@magitekltd.com \
--cc=linux-audit@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox