From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Paris Subject: Re: [PATCH RFC] audit: provide namespace information in user originated records Date: Wed, 20 Mar 2013 14:42:04 -0400 Message-ID: <1363804924.2333.12.camel@localhost> References: <1363619405-6419-1-git-send-email-arozansk@redhat.com> <877gl48iaz.fsf@xmission.com> <20130319122408.GC20187@redhat.com> <874ng7gcst.fsf@xmission.com> <20130320154503.GF20187@redhat.com> <20130320183652.GA13839@sergelap> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130320183652.GA13839@sergelap> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Serge Hallyn Cc: Linux Containers , linux-audit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, "Eric W. Biederman" List-Id: linux-audit@redhat.com On Wed, 2013-03-20 at 13:36 -0500, Serge Hallyn wrote: > Quoting Aristeu Rozanski (arozansk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org): > > This is a bit fuzzy to me, perhaps due I'm not fully understanding > > userns implementation yet, so bear with me: > > I thought of changing so userns would not grant CAP_AUDIT_WRITE and > > CAP_AUDIT_CONTROL unless the process already has it (i.e. it'd require > > Seems like CAP_AUDIT_WRITE should be targeted against the > skb->netns->userns. Then CAP_AUDIT_WRITE can be treated like any other > capability. Last I knew (long time ago) you had to be in init_user_ns > to talk audit, but that's ok - this would just do the right thing in > any case. kauditd should be considered as existing in the init user namespace. So I'd think we'd want to check if the process had CAP_AUDIT_WRITE in the init user namespace and if so, allow it to send messages. Who care what *ns the process exists in. If it has it in the init namespace, go ahead. Thus the process that created the container would need CAP_AUDIT_WRITE in the init namespace for this to all work, right? /me also gets so confused about what caps mean in the userns world. (/me has larger issues with the ns concept as a whole, but that boat sailed years and years ago)