public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Eric Paris <eparis@redhat.com>
To: Paul Moore <pmoore@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: ABIs, syscall tables, and the AUDIT_ARCH_* defines
Date: Tue, 29 Oct 2013 17:29:41 -0400	[thread overview]
Message-ID: <1383082181.28218.7.camel@flatline.rdu.redhat.com> (raw)
In-Reply-To: <1497730.rRcDeUs2mQ@sifl>

On Tue, 2013-10-29 at 17:28 -0400, Paul Moore wrote:

> Take x86_64 and x32 as an example (think of x32 as a 32-bit version of 
> x86_64).  Both x32 and x86_64 use the AUDIT_ARCH_X86_64 value and general 
> calling convention, but they have a different syscall table.

I guess a good question is "is that right" ?

#define AUDIT_ARCH_X86_64 (EM_X86_64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE)

Would we not be better off with a:

#define AUDIT_ARCH_X32 (EM_X86_64|__AUDIT_ARCH_LE)   ?

Do x86_64 and x32 share the same syscall entry code?  Is there where the
AUDIT_ARCH_X86_64 comes from?  Is this similar for ARM?  Right now, the
only thing we have is:

#define AUDIT_ARCH_ARM          (EM_ARM|__AUDIT_ARCH_LE)
#define AUDIT_ARCH_ARMEB        (EM_ARM)

Is this enough?  Should we add more?  I'm way way way more ARM idiotic
than I am about x86_64.  I know the ARM people at least told us that ARM
wasn't going to work right with what we have today...  So they added to
the audit Kconfig:

depends on AUDIT && (X86 || PPC || S390 || IA64 || UML || SPARC64 ||
SUPERH || (ARM && AEABI && !OABI_COMPAT))

Is fixing this with differentiated AUDIT_ARCH flags even possible?  Am I
just talking out of my bum?

  reply	other threads:[~2013-10-29 21:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-29 21:28 ABIs, syscall tables, and the AUDIT_ARCH_* defines Paul Moore
2013-10-29 21:29 ` Eric Paris [this message]
2013-10-29 21:56   ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383082181.28218.7.camel@flatline.rdu.redhat.com \
    --to=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=pmoore@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox