From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Paris Subject: Re: [PATCH 1/3] audit: fix incorrect order of log new and old feature Date: Thu, 31 Oct 2013 11:49:46 -0400 Message-ID: <1383234586.3510.4.camel@localhost> References: <1383208078-22117-1-git-send-email-gaofeng@cn.fujitsu.com> <20131031153945.GC3399@madcap2.tricolour.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131031153945.GC3399@madcap2.tricolour.ca> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Richard Guy Briggs Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On Thu, 2013-10-31 at 11:39 -0400, Richard Guy Briggs wrote: > On Thu, Oct 31, 2013 at 04:27:56PM +0800, Gao feng wrote: > > Signed-off-by: Gao feng > > Gao, > > Could you provide some description, justification and references for > each of the patches in this patchset please? Gao, you may also included my Acked-by: on all three. I thought the descriptions in the subject were enough, but if you can include a sentence in the body that would be great. > > > --- > > kernel/audit.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/audit.c b/kernel/audit.c > > index 7c7c028..f16f835 100644 > > --- a/kernel/audit.c > > +++ b/kernel/audit.c > > @@ -664,7 +664,7 @@ static void audit_log_feature_change(int which, u32 old_feature, u32 new_feature > > struct audit_buffer *ab; > > > > ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_FEATURE_CHANGE); > > - audit_log_format(ab, "feature=%s new=%d old=%d old_lock=%d new_lock=%d res=%d", > > + audit_log_format(ab, "feature=%s old=%d new=%d old_lock=%d new_lock=%d res=%d", > > audit_feature_names[which], !!old_feature, !!new_feature, > > !!old_lock, !!new_lock, res); > > audit_log_end(ab); > > -- > > 1.8.3.1 > > > > - RGB > > -- > Richard Guy Briggs > Senior Software Engineer > Kernel Security > AMER ENG Base Operating Systems > Remote, Ottawa, Canada > Voice: +1.647.777.2635 > Internal: (81) 32635 > Alt: +1.613.693.0684x3545