From: William Roberts <bill.c.roberts@gmail.com>
To: sds@tycho.nsa.gov, rgb@redhat.com, linux-audit@redhat.com
Subject: [RFC][PATCH] - auditing cmdline
Date: Tue, 7 Jan 2014 12:43:59 -0800 [thread overview]
Message-ID: <1389127440-974-1-git-send-email-wroberts@tresys.com> (raw)
Just some updates from the review that I have gathered.
1. Possibility of accessing invalid memory on res being 0.
2. Do not switch ordering of fields.
Does anyone hate using the boolean expression to get my
increment value? Removes some branches. Based on my
loose understanding that boolean operators are guarenteed
to be 0 or 1. Although I am never a big fan of stuff like
this in general. Should I just do the branches?
http://c-faq.com/bool/bool2.html
[PATCH] squash: review-updates
next reply other threads:[~2014-01-07 20:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 20:43 William Roberts [this message]
2014-01-07 20:44 ` [PATCH] squash: review-updates William Roberts
2014-01-08 16:01 ` William Roberts
2014-01-08 16:10 ` Richard Guy Briggs
2014-01-10 21:08 ` Eric Paris
2014-01-10 21:33 ` Eric Paris
2014-01-10 21:37 ` William Roberts
2014-01-10 21:42 ` William Roberts
-- strict thread matches above, loose matches on Subject: below --
2013-12-11 16:10 [RFC] [PATCH] - auditing cmdline William Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389127440-974-1-git-send-email-wroberts@tresys.com \
--to=bill.c.roberts@gmail.com \
--cc=linux-audit@redhat.com \
--cc=rgb@redhat.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox