public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Eric Paris <eparis@redhat.com>
To: Steve Grubb <sgrubb@redhat.com>
Cc: Richard Guy Briggs <rgb@redhat.com>, linux-audit@redhat.com
Subject: Re: [PATCH] loginuid change logging details
Date: Mon, 03 Feb 2014 12:43:50 -0500	[thread overview]
Message-ID: <1391449430.13157.7.camel@localhost> (raw)
In-Reply-To: <6186502.PS9WMGW4WR@x2>

On Mon, 2014-02-03 at 12:03 -0500, Steve Grubb wrote:
> On Monday, January 20, 2014 11:44:49 AM Eric Paris wrote:
> > I think this just touches the surface of what be/have been done.  There
> > appears to be no logic, consistency, or predictability to audit logs.
> 
> Kernel maintainers have not added all the fields I have asked for at some 
> points. I think it was proposed to add a syscall record to everything which I 
> absolutely do not want to see. that is too much information.

Where did you ask?  That's the whole point of this e-mail, and I finish
reading your response and still don't know the answer...

> What is required is this:

> 2) who did it

This is the only part that we have question/inconsistency/stoopidity
with, that I can see.  But I still don't know how to solve it.

> #2 depends on which API the action occurred on and if we have a MAC subsystem 
> or not.

What does MAC have to do with it?

>  For netlink, we are limited to what rides along in the skb.

Not true. (this was true in the past, but not for years).  We (in
kernel) know everything about the task that sends a netlink message.

The place we have the least information is in the kaudit code storing
who sent a signal to auditd.  I'll avoid that nightmare though...

> For the 
> syscall interface, we have everything. For actions through /proc, we probably 
> can have everything.  Then there are various events embedded in the kernel 
> like the IMA events which trigger when they get loaded. So, what is necessary 
> to identify the subject? In descending order of importance: 

> auid, uid, ses, 
> tty, pid, subj, exe, comm, euid, gid, egid, everything else.

Ok, so you want these from every audit event?  All of these?  And these
are all that matter?  What does 'everything else' mean?  Do we want
more?  Do we not?

That's the point of the question.  What fields about the task doing an
operation should be included in events....

> > What is the minimal set of information we should be sending with every
> > record that uniquely identifies a process?  Why is every record it's own
> > little world?
> 
> To save disk space. That is paramount. We cannot add syscall to everything 
> without eating up a lot of disk space. The main thing to remember is that 
> people who really use auditing never have enough disk space to keep everything 
> they want. So, we should always consider doing anything possible to minimize 
> disk usage no matter what.

Bam, back to senseless non-uniform mishmash mess....

  reply	other threads:[~2014-02-03 17:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-17 23:34 [PATCH] loginuid change logging details Richard Guy Briggs
2014-01-17 23:34 ` [PATCH] audit: log task context when setting loginuid Richard Guy Briggs
2014-01-20 16:44 ` [PATCH] loginuid change logging details Eric Paris
2014-02-03 17:03   ` Steve Grubb
2014-02-03 17:43     ` Eric Paris [this message]
2014-02-03 22:38       ` Steve Grubb
2014-02-03 16:40 ` Steve Grubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391449430.13157.7.camel@localhost \
    --to=eparis@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=rgb@redhat.com \
    --cc=sgrubb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox