From: Eric Paris <eparis@redhat.com>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: Richard Guy Briggs <rgb@redhat.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-audit@redhat.com
Subject: Re: [PATCH] integrity: get comm using lock to avoid race in string printing
Date: Wed, 02 Apr 2014 14:18:36 -0400 [thread overview]
Message-ID: <1396462716.2608.1.camel@localhost> (raw)
In-Reply-To: <1396462368.20325.26.camel@dhcp-9-2-203-236.watson.ibm.com>
On Wed, 2014-04-02 at 14:12 -0400, Mimi Zohar wrote:
> On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote:
> > Hello Mimi,
> >
> > On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote:
> > > This change is already being upstreamed as commit 73a6b44 "Integrity:
> > > Pass commname via get_task_comm()".
> >
> > While I was looking at Richard's patch, I noticed a few places where cause and
> > op are logged and the string isn't tied together with a _ or -. These are in
> > ima/ima_appraise.c line 383, and ima/ima_policy.c lines 333, 657, and 683. Are
> > these fixed upstream? Or should a patch be made?
>
> Nothing has changed in terms of 'cause' and 'op'. I would suggest
> making the changes in integrity_audit.c: integrity_audit_msg().
The question is actually, do you know of anyone who is expecting the
space, instead of a more 'audit standard' - or _ ? If not, we'll change
it. If so, we'll discuss more :)
-Eric
next prev parent reply other threads:[~2014-04-02 18:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 16:19 [PATCH] integrity: get comm using lock to avoid race in string printing Richard Guy Briggs
2014-04-02 17:39 ` Mimi Zohar
2014-04-02 18:00 ` Steve Grubb
2014-04-02 18:12 ` Mimi Zohar
2014-04-02 18:18 ` Eric Paris [this message]
2014-04-02 18:27 ` Mimi Zohar
2014-04-02 18:52 ` oraphaned keywords in audit log text [was: Re: [PATCH] integrity: get comm using lock to avoid race in string] printing Richard Guy Briggs
2014-06-14 0:02 ` Richard Guy Briggs
2014-06-14 9:43 ` [Linux-ima-user] " Dmitry Kasatkin
2014-06-15 1:46 ` Mimi Zohar
2014-06-15 2:45 ` Richard Guy Briggs
2014-04-02 18:45 ` [PATCH] integrity: get comm using lock to avoid race in string printing Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396462716.2608.1.camel@localhost \
--to=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=rgb@redhat.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox