Re: [PATCH] i386/audit: stop scribbling on the stack frame

Ingo Molnar
2014-10-28T06:30:01Z

* Eric Paris <eparis@redhat.com> wrote:

> On Mon, 2014-10-27 at 10:02 -0700, H. Peter Anvin wrote:
> > On 10/27/2014 06:55 AM, Eric Paris wrote:
> > > My patch was already committed to the -tip urgent branch. I believe any
> > > optimization should be based on that branch, Richard. If you are trying
> > > to wrangle every bit of speed out of this, should you
> > >
> > > push %esi;
> > > push %edi;
> > > CFI_ADJUST_CFA_OFFSET 8
> > > call __audit_syscall_entry
> > > pop;
> > > pop;
> > > CFI_ADJUST_CFA_OFFSET -8
> > >
> > > Instead of using the pushl_cfi and popl_cfi macros?
> > >
> > > I wrote my patch to be obviously correct, but agree there are certainly
> > > some speedups possible.
> > >
> >
> > Uh... not only is that plain wrong (the CFI should be adjusted after
> > each instruction that changes the stack pointer),
>
> Sure, things would be screwed up between the two push's
>
> > but what the heck is
> > wrong with using the macros?
>
> I was asking if that would save an instruction or two by
> consolidating the CFI update and if so would that tradeoff be
> worth it, given the regularity of this code being run.

CFI updates have no effect on runtime behavior whatsoever (they
don't emit any instructions), they only affect the debug info
being constructed.

Thanks,

Ingo