Re: [PATCH] i386/audit: stop scribbling on the stack frame

Thomas Gleixner
2014-10-27T21:18:21Z

On Mon, 27 Oct 2014, Eric Paris wrote:

> My patch was already committed to the -tip urgent branch. I believe any
> optimization should be based on that branch, Richard. If you are trying
> to wrangle every bit of speed out of this, should you
>
> push %esi;
> push %edi;
> CFI_ADJUST_CFA_OFFSET 8

Wrong. You want to use pushl_cfi as you need the CFI adjustment after
each modification of esp.

> call __audit_syscall_entry
> pop;
> pop;
> CFI_ADJUST_CFA_OFFSET -8
>
> Instead of using the pushl_cfi and popl_cfi macros?

Wrong again. See above. Aside of that, why do you want to use pop at
all? All we care about is adjusting esp, right?

Thanks,

tglx