From: Eric Paris <eparis@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] audit: don't attempt to lookup PIDs when changing PID filtering audit rules
Date: Mon, 15 Dec 2014 13:51:52 -0500 [thread overview]
Message-ID: <1418669512.3145.4.camel@redhat.com> (raw)
In-Reply-To: <20141215185057.GA6439@madcap2.tricolour.ca>
On Mon, 2014-12-15 at 13:50 -0500, Richard Guy Briggs wrote:
> On 14/12/15, Eric Paris wrote:
> > Lets say I and in the non-init pid namespace.
> >
> > I run audictl -a exit,always -S all -F pid=1
>
> That's easy (for now). Line 675 of kernel/audit.c in audit_netlink_ok()
> called from audit_receive_msg() will prevent that with:
>
> if ((task_active_pid_ns(current) != &init_pid_ns))
> return -EPERM;
>
> > Is the audit system going to show records for what I think is pid=1 or
> > what the initial pid namespace thinks is pid=1 ?
ACK from me then.
next prev parent reply other threads:[~2014-12-15 18:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 17:14 [PATCH] audit: don't attempt to lookup PIDs when changing PID filtering audit rules Paul Moore
2014-12-15 17:29 ` Eric Paris
2014-12-15 18:50 ` Richard Guy Briggs
2014-12-15 18:51 ` Eric Paris [this message]
2014-12-15 19:15 ` Paul Moore
2014-12-15 19:33 ` Richard Guy Briggs
2014-12-15 19:58 ` Paul Moore
2014-12-15 19:14 ` Paul Moore
2014-12-15 19:03 ` Paul Moore
2014-12-15 21:14 ` Steve Grubb
2014-12-15 21:24 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418669512.3145.4.camel@redhat.com \
--to=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).