From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] audit: removing unused variable Date: Wed, 28 Oct 2015 15:12:53 -0700 Message-ID: <1446070373.2757.147.camel@perches.com> References: <1446005434-4306-1-git-send-email-saurabh.truth@gmail.com> <7739343.KgmgksQykM@sifl> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <7739343.KgmgksQykM@sifl> Sender: linux-kernel-owner@vger.kernel.org To: Paul Moore Cc: Saurabh Sengar , eparis@redhat.com, linux-audit@redhat.com, linux-kernel@vger.kernel.org List-Id: linux-audit@redhat.com On Wed, 2015-10-28 at 16:35 -0400, Paul Moore wrote: > On Wednesday, October 28, 2015 09:40:34 AM Saurabh Sengar wrote: > > variavle rc in not required as it is just used for unchanged for return, > > and return is always 0 in the function. [] > Thanks, applied with some spelling corrections to the description. As the return value is never actually tested, it seems better to make it a void function, > > diff --git a/kernel/audit.c b/kernel/audit.c [] > > @@ -686,23 +686,22 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 > > msg_type) > > > > static int audit_log_common_recv_msg(struct audit_buffer **ab, u16 > > msg_type) { > > - int rc = 0; > > uid_t uid = from_kuid(&init_user_ns, current_uid()); > > pid_t pid = task_tgid_nr(current); > > > > if (!audit_enabled && msg_type != AUDIT_USER_AVC) { > > *ab = NULL; > > - return rc; > > + return 0; > > } > > > > *ab = audit_log_start(NULL, GFP_KERNEL, msg_type); > > if (unlikely(!*ab)) > > - return rc; > > + return 0; > > audit_log_format(*ab, "pid=%d uid=%u", pid, uid); > > audit_log_session_info(*ab); > > audit_log_task_context(*ab); > > > > - return rc; > > + return 0; > > } > > > > int is_audit_feature_set(int i) >