Re: [PATCH V4] powerpc: add little endian flag to syscall_get_arch()

Richard Guy Briggs
2014-12-10T02:43:19Z

On 14/12/10, Michael Ellerman wrote:
> On Tue, 2014-12-09 at 21:11 -0500, Paul Moore wrote:
> > On Tuesday, December 09, 2014 03:37:07 PM Richard Guy Briggs wrote:
> > > Since both ppc and ppc64 have LE variants which are now reported by uname,
> > > add that flag (__AUDIT_ARCH_LE) to syscall_get_arch() and add
> > > AUDIT_ARCH_PPC64LE variant.
> > >
> > > Without this, perf trace and auditctl fail.
> > >
> > > Mainline kernel reports ppc64le (per a058801) but there is no matching
> > > AUDIT_ARCH_PPC64LE.
> > >
> > > Since 32-bit PPC LE is not supported by audit, don't advertise it in
> > > AUDIT_ARCH_PPC* variants.
> > >
> > > See:
> > > https://www.redhat.com/archives/linux-audit/2014-August/msg00082.html
> > > https://www.redhat.com/archives/linux-audit/2014-December/msg00004.html
> > >
> > > Signed-off-by: Richard Guy Briggs <rgb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > ---
> > > arch/powerpc/include/asm/syscall.h | 6 +++++-
> > > include/uapi/linux/audit.h | 2 ++
> > > 2 files changed, 7 insertions(+), 1 deletions(-)
> >
> > The audit changes look fine to me, but as I mentioned earlier, this should go
> > in via the ppc tree and not the audit tree.
> >
> > Acked-by: Paul Moore <paul-r2n+y4ga6xFZroRs9YW3xA@public.gmane.org>
>
> Thanks.
>
> Yep I'll take it via the powerpc tree, I'll CC stable as well as presumably we
> want this to work in all versions that had LE support.

Yes, please!

(I was very tempted to change the #error to #warning, but figured the
placeholder comment in the uapi file was sufficient.)

> cheers

- RGB

--
Richard Guy Briggs <rbriggs-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Senior Software Engineer, Kernel Security, AMER ENG Base Operating Systems, Red Hat
Remote, Ottawa, Canada
Voice: +1.647.777.2635, Internal: (81) 32635, Alt: +1.613.693.0684x3545