From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
Cc: linux-integrity@vger.kernel.org, linux-audit@redhat.com
Subject: Re: result logged in integrity audit message
Date: Sat, 06 Jun 2020 21:51:50 -0400 [thread overview]
Message-ID: <1591494710.4615.49.camel@linux.ibm.com> (raw)
In-Reply-To: <4c41ce1e-3f97-5b14-8152-5411a3debb57@linux.microsoft.com>
Hi Lakshmi,
On Fri, 2020-06-05 at 20:13 -0700, Lakshmi Ramasubramanian wrote:
> Hi Mimi,
>
> In integrity audit message function the inverse of "result" is being
> logged for "res=". Please see below. Is this intentional?
>
> void integrity_audit_msg(int audit_msgno, struct inode *inode,
> const unsigned char *fname, const char *op,
> const char *cause, int result, int audit_info)
> {
>
> ...
> audit_log_format(ab, " res=%d", !result);
> }
>
> The callers of this function are passing an error code (-ENOMEM,
> -EINVAL, etc.) in the "result" parameter. But that error code is lost -
> instead "res" is set to 0.
>
> For example,
>
> audit: type=1804 audit(1591411737.631:3): pid=1 uid=0 auid=4294967295
> ses=4294967295 subj=kernel op=ima_alloc_key_entry cause=ENOMEM
> comm="swapper/0" name=".builtin_trusted_keys" res=0
The commit message provides an explanation. Look at b0d5de4d5880 ("IMA: fix
audit res field to indicate 1 for success and 0 for failure").
Mimi
--
Linux-audit mailing list
Linux-audit@redhat.com
https://www.redhat.com/mailman/listinfo/linux-audit
next prev parent reply other threads:[~2020-06-08 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 3:13 result logged in integrity audit message Lakshmi Ramasubramanian
2020-06-07 1:51 ` Mimi Zohar [this message]
2020-06-07 5:36 ` Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591494710.4615.49.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=linux-audit@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=nramas@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox