Linux-audit Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Laurent Bigonville <bigon@debian.org>
Cc: linux-audit@redhat.com
Subject: Re: Missing linker flags when statically linking
Date: Sat, 09 Jul 2016 17:41:17 -0400	[thread overview]
Message-ID: <1593477.8QKBr1tzSR@x2> (raw)
In-Reply-To: <c48d063c-55c1-ea02-5586-423ed0863264@debian.org>

On Saturday, July 9, 2016 11:02:44 PM EDT Laurent Bigonville wrote:
> Le 05/07/16 à 14:15, Steve Grubb a écrit :
> > Hello,
> > 
> > On Monday, July 4, 2016 2:08:14 PM EDT Laurent Bigonville wrote:
> >> Apparently the audit.pc file is missing flags to allow libaudit to be
> >> statically linked (see [0]).
> >> 
> >> Adding something like "Requires.private: libcap-ng" should fix the
> >> problem.
> > 
> > OK. Fixed. There will be a new audit package release in a little while
> > that
> > has this fixed.
> 
> Apparently the fix is not 100% correct:
> 
> The "Libs.private" field should be _after_ the Libs one in the .pc file,
> otherwise the ordering of the libraries is not OK during liking:
> 
> -lcap-ng -laudit
> 
> it should be: -laudit -lcap-ng instead.

OK, I switched the order.


> Also any reasons you are using Libs.private instead of Package.private?

Libs.private is used to add flags for static linking. The dynamic linker 
shouldn't need a hint since libaudit its already linked to libcap-ng.

Also, anyone packaging up audit 2.6.4 will want to include this patch:
https://fedorahosted.org/audit/changeset/1340

-Steve

  reply	other threads:[~2016-07-09 21:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-04 12:08 Missing linker flags when statically linking Laurent Bigonville
2016-07-05 12:15 ` Steve Grubb
2016-07-09 21:02   ` Laurent Bigonville
2016-07-09 21:41     ` Steve Grubb [this message]
2016-07-10  8:45       ` Laurent Bigonville
2016-07-10 12:17         ` Thomas Petazzoni
2016-07-10 17:18         ` Steve Grubb
2016-07-10 17:42           ` Laurent Bigonville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1593477.8QKBr1tzSR@x2 \
    --to=sgrubb@redhat.com \
    --cc=bigon@debian.org \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox