From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [PATCH V3 2/2] audit: log failed attempts to change audit_pid configuration Date: Tue, 22 Dec 2015 18:47:49 -0500 Message-ID: <1598949.6T5upxUe0W@sifl> References: <0fae992f25a20225e0bfae9281a978259c76330e.1450773773.git.rgb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <0fae992f25a20225e0bfae9281a978259c76330e.1450773773.git.rgb@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Richard Guy Briggs Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, sgrubb@redhat.com, eparis@redhat.com, v.rathor@gmail.com, ctcard@hotmail.com List-Id: linux-audit@redhat.com On Tuesday, December 22, 2015 04:03:07 AM Richard Guy Briggs wrote: > Failed attempts to change the audit_pid configuration are not presently > logged. One case is an attempt to starve an old auditd by starting up a > new auditd when the old one is still alive and active. The other case > is an attempt to orphan a new auditd when an old auditd shuts down. > > Log both as AUDIT_CONFIG_CHANGE messages with failure result. > > Signed-off-by: Richard Guy Briggs > --- > kernel/audit.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) Same as 1/2, applied to the audit next queue. > diff --git a/kernel/audit.c b/kernel/audit.c > index 0368be2..9000c6f 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -882,11 +882,15 @@ static int audit_receive_msg(struct sk_buff *skb, > struct nlmsghdr *nlh) int new_pid = s.pid; > pid_t requesting_pid = task_tgid_vnr(current); > > - if ((!new_pid) && (requesting_pid != audit_pid)) > + if ((!new_pid) && (requesting_pid != audit_pid)) { > + audit_log_config_change("audit_pid", new_pid, audit_pid, 0); > return -EACCES; > + } > if (audit_pid && new_pid && > - audit_replace(requesting_pid) != -ECONNREFUSED) > + audit_replace(requesting_pid) != -ECONNREFUSED) { > + audit_log_config_change("audit_pid", new_pid, audit_pid, 0); > return -EEXIST; > + } > if (audit_enabled != AUDIT_OFF) > audit_log_config_change("audit_pid", new_pid, audit_pid, 1); > audit_pid = new_pid; -- paul moore security @ redhat