From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: libauparse exporting clear_config() Date: Fri, 11 Apr 2014 09:42:50 -0400 Message-ID: <1608421.DSTyeOvgW3@x2> References: <20140410090611.1ec70e97@fornost.bigon.be> <4788452.agzjWCmXC5@x2> <20140411085437.2732fd55@fornost.bigon.be> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20140411085437.2732fd55@fornost.bigon.be> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Laurent Bigonville Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On Friday, April 11, 2014 08:54:37 AM Laurent Bigonville wrote: > Le Thu, 10 Apr 2014 07:25:42 -0400, > = > Steve Grubb a =E9crit : > > On Thursday, April 10, 2014 09:06:11 AM Laurent Bigonville wrote: > > > With 2.3.5, libauparse is exporting a new symbol (clear_config()) > > > = > > > It seems that all the other symbols are prefixed with either > > > auparse_ or audit_, so is this expected? > > = > > No, this was not expected. It should be an internal use only > > function. Is this causing any symbol collision in a known program? > = > Searching[0] quickly in the code that is present in the debian archive, > I see that at least lxc has the same function name, but I didn't > encounter collision myself. Thanks for checking this. I don't think lxr would be using auparse, so I th= ink = we are safe. That said, the fix is to add the following: void clear_config(struct daemon_conf *config) hidden; to auparse/internal.h and then recompile. It's already in svn and will be i= n = the next release, which should be in the next week or so. > Apparently libaudit also has some symbols that are not prefixed > by audit_[1], but these seems a bit less generic than "clear_config()" Thanks. I don't see anything here likely to cause a collision. -Steve > [0] http://codesearch.debian.net/ > [1] > http://anonscm.debian.org/gitweb/?p=3Dcollab-maint/audit.git;a=3Dblob;f= =3Ddebian/l > ibaudit1.symbols;h=3D1d1af3e008ab7858b3e6996563a9a9a5b4aa7723;hb=3DHEAD