From mboxrd@z Thu Jan  1 00:00:00 1970
From: Paul Moore <pmoore@redhat.com>
Subject: Re: [PATCH] audit: don't attempt to lookup PIDs when changing PID
	filtering audit rules
Date: Mon, 15 Dec 2014 14:15:16 -0500
Message-ID: <16312766.Oe1UCGEpHS@sifl>
References: <20141215171414.30169.46068.stgit@localhost>
	<20141215185057.GA6439@madcap2.tricolour.ca>
	<1418669512.3145.4.camel@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <1418669512.3145.4.camel@redhat.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Eric Paris <eparis@redhat.com>
Cc: Richard Guy Briggs <rgb@redhat.com>, linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On Monday, December 15, 2014 01:51:52 PM Eric Paris wrote:
> On Mon, 2014-12-15 at 13:50 -0500, Richard Guy Briggs wrote:
> > On 14/12/15, Eric Paris wrote:
> > > Lets say I and in the non-init pid namespace.
> > > 
> > > I run audictl -a exit,always -S all -F pid=1
> > 
> > That's easy (for now).  Line 675 of kernel/audit.c in audit_netlink_ok()
> > 
> > called from audit_receive_msg() will prevent that with:
> > 	if ((task_active_pid_ns(current) != &init_pid_ns))
> > 	
> > 		return -EPERM;
> > 		
> > > Is the audit system going to show records for what I think is pid=1 or
> > > what the initial pid namespace thinks is pid=1 ?
> 
> ACK from me then.

Okay, thanks.  Anybody else want to jump on the Ack/Review bandwagon?

-- 
paul moore
security and virtualization @ redhat