[PATCH 1/1] Obsolete check is now removed.

[PATCH 1/1] Obsolete check is now removed.

[Mikhail Klementyev]

[-- Attachment #1.1: Type: text/plain, Size: 1796 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

- From a2e33ce7c9b5ceff2a8b570b570ddd0023ce077f Mon Sep 17 00:00:00 2001
From: Mikhail Klementyev<jollheef@riseup.net>
Date: Mon, 25 May 2015 23:20:38 +0300
Subject: [PATCH 1/1] Obsolete check is now removed.

Signed-off-by: Mikhail Klementyev<jollheef@riseup.net>
- ---
  kernel/auditsc.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/auditsc.c b/kernel/auditsc.c
index 9fb9d1c..ee09794 100644
- --- a/kernel/auditsc.c
+++ b/kernel/auditsc.c
@@ -599,9 +599,7 @@ static int audit_filter_rules(struct task_struct *tsk,
  				result = match_tree_refs(ctx, rule->tree);
  			break;
  		case AUDIT_LOGINUID:
- -			result = 0;
- -			if (ctx)
- -				result = audit_uid_comparator(tsk->loginuid, f->op, f->uid);
+			result = audit_uid_comparator(tsk->loginuid, f->op, f->uid);
  			break;
  		case AUDIT_LOGINUID_SET:
  			result = audit_comparator(audit_loginuid_set(tsk), f->op, f->val);
- -- 
2.0.5

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVY4cJAAoJEE7XYCHzWN5TQVkQAMYCSkzSlIVA9sTmrZk0bDA1
62pbY22hEFfWN41268hjhhQ/wiuM14LI34oTeCPnqxQIopTt9bnAW9ZwPfgNFG2F
T/nSLZVJMwjjs/b1DrAV4fDWYtlIjedm/HhhumFIyOfDkAPIgs2cBcWiGkB6D9ly
oi/ccMaTo4c59kfTwCjYKgpY8iPMdm547fR8YVEt+eX+nfJSMbCcrnkBoFoZl4tk
RHjKmuTyjJ9U5ht94Rws/xKMYQ+g+I+CV6L1FpzOY9ZVaFLelsOJKiipkXMemwih
NCC4qtd6HF/rbd0jFQpzU1QViw7y/ZxcduAmqmr7yg1oxNYqhzt9OIcKlH1QWqrQ
eKdPDxd23n+t9yri1cIExb0Cik6ySRR0lRn/IOfSAgaJAZX0r5+Db+LkWYymXgHp
D8edl1WvpjkNo+R/GjNvaDM9jKB3Z6FblUlteqMQB9mCnwys3YKcc4ma5aGXbO24
fF28r632nDZrj+knIU171VtEyEjbnzo05bJnIiOW167STKBmbFgHgGTI/yhCHBro
wp6kg0ns+WK3tE+BvXhG/iysTAUvAhf/bnMlFaZ8j1GGhEzWGJveDINEIcCzRsoR
UncA/96yN4Sqw1Acq5+s9SaD+NMt++Iz1JbYck8rpJlO8zgpxF/6lb9Fz1B9o/LH
B20jap46V3UDEjzEp3DS
=Puu1
-----END PGP SIGNATURE-----


[-- Attachment #1.2: Type: text/html, Size: 2307 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 1/1] Obsolete check is now removed.

[Paul Moore]

On Wednesday, May 27, 2015 04:41:05 PM Mikhail Klementyev wrote:
> From a2e33ce7c9b5ceff2a8b570b570ddd0023ce077f Mon Sep 17 00:00:00 2001
> From: Mikhail Klementyev<jollheef@riseup.net>
> Date: Mon, 25 May 2015 23:20:38 +0300
> Subject: [PATCH 1/1] Obsolete check is now removed.
> 
> Signed-off-by: Mikhail Klementyev<jollheef@riseup.net>
> ---
>   kernel/auditsc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)

Applied, but you are lucky I happened to be in a good mood and your patch was 
small, normally I reject patches that arrive as HTML mail because they are a 
major headache to apply.

Contributions are always welcome, but please read the information in the 
Documentation/SubmittingPatches before submitting another patch.

> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 9fb9d1c..ee09794 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -599,9 +599,7 @@ static int audit_filter_rules(struct task_struct *tsk,
>   				result = match_tree_refs(ctx, rule->tree);
>   			break;
>   		case AUDIT_LOGINUID:
> -			result = 0;
> -			if (ctx)
> -				result = audit_uid_comparator(tsk->loginuid, f->op, f->uid);
> +			result = audit_uid_comparator(tsk->loginuid, f->op, f->uid);
>   			break;
>   		case AUDIT_LOGINUID_SET:
>   			result = audit_comparator(audit_loginuid_set(tsk), f->op, f-
>val);
> --
> 2.0.5

-- 
paul moore
www.paul-moore.com