From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [PATCH 1/1] Obsolete check is now removed. Date: Fri, 29 May 2015 16:15:25 -0400 Message-ID: <1670382.DmuLZR64zR@sifl> References: <5565C971.8020001@riseup.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (ext-mx04.extmail.prod.ext.phx2.redhat.com [10.5.110.28]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4TKFWmu016932 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 29 May 2015 16:15:32 -0400 Received: from mail-qk0-f182.google.com (mail-qk0-f182.google.com [209.85.220.182]) by mx1.redhat.com (Postfix) with ESMTPS id 38A982CD813 for ; Fri, 29 May 2015 20:15:31 +0000 (UTC) Received: by qkhg32 with SMTP id g32so51331795qkh.0 for ; Fri, 29 May 2015 13:15:30 -0700 (PDT) In-Reply-To: <5565C971.8020001@riseup.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Mikhail Klementyev Cc: rgb@redhat.com, linux-audit@redhat.com List-Id: linux-audit@redhat.com On Wednesday, May 27, 2015 04:41:05 PM Mikhail Klementyev wrote: > From a2e33ce7c9b5ceff2a8b570b570ddd0023ce077f Mon Sep 17 00:00:00 2001 > From: Mikhail Klementyev > Date: Mon, 25 May 2015 23:20:38 +0300 > Subject: [PATCH 1/1] Obsolete check is now removed. > > Signed-off-by: Mikhail Klementyev > --- > kernel/auditsc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Applied, but you are lucky I happened to be in a good mood and your patch was small, normally I reject patches that arrive as HTML mail because they are a major headache to apply. Contributions are always welcome, but please read the information in the Documentation/SubmittingPatches before submitting another patch. > diff --git a/kernel/auditsc.c b/kernel/auditsc.c > index 9fb9d1c..ee09794 100644 > --- a/kernel/auditsc.c > +++ b/kernel/auditsc.c > @@ -599,9 +599,7 @@ static int audit_filter_rules(struct task_struct *tsk, > result = match_tree_refs(ctx, rule->tree); > break; > case AUDIT_LOGINUID: > - result = 0; > - if (ctx) > - result = audit_uid_comparator(tsk->loginuid, f->op, f->uid); > + result = audit_uid_comparator(tsk->loginuid, f->op, f->uid); > break; > case AUDIT_LOGINUID_SET: > result = audit_comparator(audit_loginuid_set(tsk), f->op, f- >val); > -- > 2.0.5 -- paul moore www.paul-moore.com