From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [PATCH] lsm: rename duplicate labels in LSM_AUDIT_DATA_TASK audit message type Date: Fri, 29 May 2015 15:15:31 -0400 Message-ID: <1678145.1EicOmLJQ4@sifl> References: <096df9441c4492ab31851eba63fee4408872d06f.1429121009.git.rgb@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <096df9441c4492ab31851eba63fee4408872d06f.1429121009.git.rgb@redhat.com> Sender: linux-security-module-owner@vger.kernel.org To: Richard Guy Briggs Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-audit@redhat.com, sgrubb@redhat.com, eparis@parisplace.org, jmorris@namei.org List-Id: linux-audit@redhat.com On Wednesday, April 15, 2015 02:08:25 PM Richard Guy Briggs wrote: > The LSM_AUDIT_DATA_TASK pid= and comm= labels are duplicates of those at the > start of this function with different values. Rename them to their object > counterparts opid= and ocomm= to disambiguate. > > Signed-off-by: Richard Guy Briggs > --- > security/lsm_audit.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. > diff --git a/security/lsm_audit.c b/security/lsm_audit.c > index b526ddc..3323144 100644 > --- a/security/lsm_audit.c > +++ b/security/lsm_audit.c > @@ -282,7 +282,7 @@ static void dump_common_audit_data(struct audit_buffer > *ab, pid_t pid = task_pid_nr(tsk); > if (pid) { > char comm[sizeof(tsk->comm)]; > - audit_log_format(ab, " pid=%d comm=", pid); > + audit_log_format(ab, " opid=%d ocomm=", pid); > audit_log_untrustedstring(ab, > memcpy(comm, tsk->comm, sizeof(comm))); > } -- paul moore security @ redhat