public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: linux-audit@redhat.com
Cc: Richard Guy Briggs <rgb@redhat.com>
Subject: Re: aulast only displaying reboot pseudo-users
Date: Tue, 17 Jun 2014 11:04:01 -0400	[thread overview]
Message-ID: <1695899.u0kqdXOYkQ@x2> (raw)
In-Reply-To: <20140617145542.GC14900@madcap2.tricolour.ca>

On Tuesday, June 17, 2014 10:55:42 AM Richard Guy Briggs wrote:
> > This feel like 2 clear bugs.
> > 
> > 1) The kernel records for LOGIN are 'malformed' in 3.14.
> 
> Yes.  That's why it got fixed for 3.15.
> 
> 	5ee9a75 audit: fix dangling keywords in audit_log_set_loginuid() output
> introduced it between 3.13 and 3.14-rc1
> 
> 	aa589a1 audit: remove superfluous new- prefix in AUDIT_LOGIN messages
> fixed it between 3.14 and 3.15-rc1
> 
> So it is fine in 3.15.

We need this fixed in current kernels. Its a low risk patch that fixes this 
problem for a lot of people.

 
> > 2) Userspace silently throws records which are 'malformed' away, instead
> > of just printing them...
> 
> So according to Linus, we (I) violated the "thou shalt not break
> userspace" golden rule with the second patch.
> 
> But it was already broken according to Steve which is why the first
> patch was submitted.
> 
> > ausearch -m LOGIN should be able to display these things...
> 
> Agreed.
> 
> One lesson here?  Let's get a minimum useful subset of
> http://people.redhat.com/sgrubb/audit/audit-parse.txt into
> linux-2.6/Documentation/ tree to try to avoid this issue in the future.

I'd like to reformat that before putting it in the linux kernel. It needs to 
be written from a generic howto perspective and not a library design 
perspective. Although that document is what has guided audit event design for 
about 8 or 9 years.

-Steve

  reply	other threads:[~2014-06-17 15:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 22:04 aulast only displaying reboot pseudo-users Laurent Bigonville
2014-06-04 22:23 ` Steve Grubb
2014-06-04 22:42   ` Laurent Bigonville
2014-06-04 23:04     ` Steve Grubb
2014-06-05 17:34       ` Laurent Bigonville
2014-06-14 11:53         ` Laurent Bigonville
2014-06-16 21:20           ` Eric Paris
2014-06-16 21:24             ` Eric Paris
2014-06-16 21:28               ` Eric Paris
2014-06-17 13:29             ` Steve Grubb
2014-06-17 14:09               ` Laurent Bigonville
2014-06-17 14:31                 ` Eric Paris
2014-06-17 14:55                   ` Richard Guy Briggs
2014-06-17 15:04                     ` Steve Grubb [this message]
2014-06-17 14:56                   ` Steve Grubb
2014-06-17 15:15                     ` Richard Guy Briggs
2014-06-17 15:26                     ` Eric Paris
2014-06-17 16:30                       ` Steve Grubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1695899.u0kqdXOYkQ@x2 \
    --to=sgrubb@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=rgb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox