Re: [RFC PATCH 4/7] audit: wake up threads if queue switched from limited to unlimited

[Paul Moore <paul@paul-moore.com>]

On Thursday, October 22, 2015 02:53:17 PM Richard Guy Briggs wrote:
> If the audit_backlog_limit is changed from a limited value to an
> unlimited value (zero) while the queue was overflowed, wake up the
> audit_backlog_wait queue to allow those processes to continue.
> 
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
>  kernel/audit.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

Looks like the right thing to do, merged to audit#next-queue.

> diff --git a/kernel/audit.c b/kernel/audit.c
> index 384a1a1..02a5ec0 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -523,7 +523,8 @@ static int kauditd_thread(void *dummy)
>  		skb = skb_dequeue(&audit_skb_queue);
> 
>  		if (skb) {
> -			if (skb_queue_len(&audit_skb_queue) <= audit_backlog_limit)
> +			if (!audit_backlog_limit ||
> +			    (skb_queue_len(&audit_skb_queue) <= audit_backlog_limit))
>  				wake_up(&audit_backlog_wait);
>  			if (audit_pid)
>  				kauditd_send_skb(skb);

-- 
paul moore
www.paul-moore.com