From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [PATCH] audit: AUDIT_FEATURE_CHANGE message format missing delimiting space Date: Thu, 30 Oct 2014 19:52:50 -0400 Message-ID: <1757100.O4Ah26UjKn@sifl> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Richard Guy Briggs Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On Thursday, October 30, 2014 11:22:53 AM Richard Guy Briggs wrote: > Add a space between subj= and feature= fields to make them parsable. > > Signed-off-by: Richard Guy Briggs > --- > kernel/audit.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied to the audit stable-3.18 branch with a CC for the -stable folks. I'll send a pull request to Linus next week, I want to wait a few days and see if we get any other fixes for v3.18. * git://git.infradead.org/users/pcmoore/audit stable-3.18 > diff --git a/kernel/audit.c b/kernel/audit.c > index 53bb39b..8ee4508 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -739,7 +739,7 @@ static void audit_log_feature_change(int which, u32 > old_feature, u32 new_feature > > ab = audit_log_start(NULL, GFP_KERNEL, AUDIT_FEATURE_CHANGE); > audit_log_task_info(ab, current); > - audit_log_format(ab, "feature=%s old=%u new=%u old_lock=%u new_lock=%u > res=%d", + audit_log_format(ab, " feature=%s old=%u new=%u old_lock=%u > new_lock=%u res=%d", audit_feature_names[which], !!old_feature, > !!new_feature, > !!old_lock, !!new_lock, res); > audit_log_end(ab); -- paul moore security and virtualization @ redhat