* Where can I find coding style guidelines for the Linux Audit framework source code?
@ 2016-08-17 13:02 Mateusz Piotrowski
2016-08-17 13:23 ` Steve Grubb
0 siblings, 1 reply; 2+ messages in thread
From: Mateusz Piotrowski @ 2016-08-17 13:02 UTC (permalink / raw)
To: linux-audit
Hello,
I wonder if there is a document describing the preferred coding style
of the Linux Audit framework source code. Is it basically the style of
the Linux Kernel[1]?
Secondly, does it make sense to submit patches which fix style only?
Cheers,
Mateusz
[1]: https://www.kernel.org/doc/Documentation/CodingStyle
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Where can I find coding style guidelines for the Linux Audit framework source code?
2016-08-17 13:02 Where can I find coding style guidelines for the Linux Audit framework source code? Mateusz Piotrowski
@ 2016-08-17 13:23 ` Steve Grubb
0 siblings, 0 replies; 2+ messages in thread
From: Steve Grubb @ 2016-08-17 13:23 UTC (permalink / raw)
To: linux-audit
On Wednesday, August 17, 2016 3:02:36 PM EDT Mateusz Piotrowski wrote:
> I wonder if there is a document describing the preferred coding style
> of the Linux Audit framework source code.
No.
> Is it basically the style of the Linux Kernel[1]?
I have never used the kernel style. But if you look at the code, its fairly
consistent - except that there are a whole lot of contributors over time. Not
everyone followed the style exactly. I try to correct it over time. The main
thing I hate is lines that are over 80 characters long or when a patch uses
spaces and not tabs.
> Secondly, does it make sense to submit patches which fix style only?
I don't like to have a lot of code churn just for style. I tend to fix style
either on patch submission. Or if its big or I don't have time, I fix it when
I'm in that area.
-Steve
> [1]: https://www.kernel.org/doc/Documentation/CodingStyle
>
> --
> Linux-audit mailing list
> Linux-audit@redhat.com
> https://www.redhat.com/mailman/listinfo/linux-audit
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-17 13:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-17 13:02 Where can I find coding style guidelines for the Linux Audit framework source code? Mateusz Piotrowski
2016-08-17 13:23 ` Steve Grubb
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).