From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: Where can I find coding style guidelines for the Linux Audit framework source code? Date: Wed, 17 Aug 2016 09:23:33 -0400 Message-ID: <1844559.dnvzoz3xS3@x2> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: linux-audit@redhat.com List-Id: linux-audit@redhat.com On Wednesday, August 17, 2016 3:02:36 PM EDT Mateusz Piotrowski wrote: > I wonder if there is a document describing the preferred coding style > of the Linux Audit framework source code. No. > Is it basically the style of the Linux Kernel[1]? I have never used the kernel style. But if you look at the code, its fairly consistent - except that there are a whole lot of contributors over time. Not everyone followed the style exactly. I try to correct it over time. The main thing I hate is lines that are over 80 characters long or when a patch uses spaces and not tabs. > Secondly, does it make sense to submit patches which fix style only? I don't like to have a lot of code churn just for style. I tend to fix style either on patch submission. Or if its big or I don't have time, I fix it when I'm in that area. -Steve > [1]: https://www.kernel.org/doc/Documentation/CodingStyle > > -- > Linux-audit mailing list > Linux-audit@redhat.com > https://www.redhat.com/mailman/listinfo/linux-audit