From: Miloslav Trmac <mitr@redhat.com>
To: Juraj Hlista <juro.hlista@gmail.com>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH] audit: Reactive rules
Date: Wed, 31 Mar 2010 14:36:05 -0400 (EDT) [thread overview]
Message-ID: <1870478057.299001270060565969.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com> (raw)
In-Reply-To: <1844882650.298781270060487513.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
Hello,
----- "Juraj Hlista" <juro.hlista@gmail.com> wrote:
> diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
> @@ -415,7 +424,8 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
> - int i;
> + int i, j = 0;
> + int k;
> @@ -425,7 +435,7 @@ static struct audit_entry
> *audit_data_to_entry(struct audit_rule_data *data,
> for (i = 0; i < data->field_count; i++) {
> - struct audit_field *f = &entry->rule.fields[i];
> + struct audit_field *f = &entry->rule.fields[i - j];
It would be more clear to have a "source index" (used for "data"), and a "destination index" (used for entry->rule.fields); "j" is currently a difference between the two.
next parent reply other threads:[~2010-03-31 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1844882650.298781270060487513.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com>
2010-03-31 18:36 ` Miloslav Trmac [this message]
2010-03-30 22:17 [PATCH] audit: Reactive rules Juraj Hlista
2010-03-30 22:23 ` Al Viro
2010-03-31 7:26 ` Juraj Hlista
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1870478057.299001270060565969.JavaMail.root@zmail07.collab.prod.int.phx2.redhat.com \
--to=mitr@redhat.com \
--cc=juro.hlista@gmail.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox