From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: [PATCH] audit: fix external header definitions for gcc10 Date: Fri, 10 Jan 2020 21:18:03 -0500 Message-ID: <1871063.F7JoL3MBZj@x2> References: <20200111000346.GA22149@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200111000346.GA22149@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Tony Jones Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On Friday, January 10, 2020 7:03:47 PM EST Tony Jones wrote: > Header definitions need to be external when building with -fno-common > (which is default in GCC 10). Applied. Thanks! -Steve > (.text+0x0): multiple definition of `event_node_list'; ausearch.o (symbol > from plugin):(.text+0x0): first defined here [ 60s] > /usr/lib64/gcc/x86_64-suse-linux/9/../../../../x86_64-suse-linux/bin/ld: > ausearch-time.o (symbol from plugin): in function `lookup_time': > > Fixes: ff25054df7ed > --- > src/ausearch-common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ausearch-common.h b/src/ausearch-common.h > index 6669203..3040547 100644 > --- a/src/ausearch-common.h > +++ b/src/ausearch-common.h > @@ -50,7 +50,7 @@ extern pid_t event_pid; > extern int event_exact_match; > extern uid_t event_uid, event_euid, event_loginuid; > extern const char *event_tuid, *event_teuid, *event_tauid; > -slist *event_node_list; > +extern slist *event_node_list; > extern const char *event_comm; > extern const char *event_filename; > extern const char *event_hostname; > -- > 2.21.0