From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: How to offer a patch Date: Tue, 02 Apr 2013 14:55:13 -0400 Message-ID: <1872448.Hxgm3VXBsz@x2> References: <1364690677.30850.18.camel@swtf.swtf.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1364690677.30850.18.camel@swtf.swtf.dyndns.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: linux-audit@redhat.com, burn@swtf.dyndns.org List-Id: linux-audit@redhat.com On Sunday, March 31, 2013 11:44:37 AM Burn Alting wrote: > I've made some mods to auditctl to allow it to read a directory of 'rule > files'. The idea is that within an enterprise, one would distribute a > standard /etc/audit/audit.rules which can be updated from the corporate > repository. Should a system require localized audit rules, then a > directory containing files of rules can be maintained locally. The > reasoning for a directory as opposed to just an additional file is to > offer granularity of 'rule sets'. See the previous email about SCAP limitations. > I would like to know the convention for patching to this list. Should I > git clone the svn repository then supply a git diff? Can I just provide > an old-fashioned diff -rupN or C_ALL=C TZ=UTC0 diff -Naur? As long as it can be applied with 'patch', I can figure out whether its -p0 or -p1. I generally go for the diff -urpN option. It probably doesn't need to be mentioned, but I don't like patches (or sections of patches) that only add formatting or white spaces to existing code. Thanks, -Steve