public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Laurent Bigonville <bigon@debian.org>
Cc: linux-audit@redhat.com
Subject: Re: libauparse exporting clear_config()
Date: Mon, 14 Apr 2014 08:06:33 -0400	[thread overview]
Message-ID: <1966211.j87hqI7kLn@x2> (raw)
In-Reply-To: <20140412144638.3bba8e69@fornost.bigon.be>

On Saturday, April 12, 2014 02:46:38 PM Laurent Bigonville wrote:
> Le Fri, 11 Apr 2014 09:42:50 -0400,
> 
> Steve Grubb <sgrubb@redhat.com> a écrit :
> > On Friday, April 11, 2014 08:54:37 AM Laurent Bigonville wrote:
> > > Le Thu, 10 Apr 2014 07:25:42 -0400,
> > > 
> > > Steve Grubb <sgrubb@redhat.com> a écrit :
> > > > On Thursday, April 10, 2014 09:06:11 AM Laurent Bigonville wrote:
> > > > > With 2.3.5, libauparse is exporting a new symbol
> > > > > (clear_config())
> > > > > 
> > > > > It seems that all the other symbols are prefixed with either
> > > > > auparse_ or audit_, so is this expected?
> > > > 
> > > > No, this was not expected. It should be an internal use only
> > > > function. Is this causing any symbol collision in a known program?
> > > 
> > > Searching[0] quickly in the code that is present in the debian
> > > archive, I see that at least lxc has the same function name, but I
> > > didn't encounter collision myself.
> > 
> > Thanks for checking this. I don't think lxr would be using auparse,
> > so I think we are safe. That said, the fix is to add the following:
> > 
> > void clear_config(struct daemon_conf *config) hidden;
> > 
> > to auparse/internal.h and then recompile. It's already in svn and
> > will be in the next release, which should be in the next week or so.
> 
> Thanks!
> 
> Something else somehow related, I just received a bugreport about the
> load_config() function being declared in both auditd core and the
> prelude plugin https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=744282

Something seems wrong with that report. the prelude plugin and auditd are two 
entirely different programs. But looking deeper, I wonder if what they meant 
was that the prelude plugin links with auparse which uses the visibility 
settings to hide a load_config function from the ABI?

-Steve

      reply	other threads:[~2014-04-14 12:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10  7:06 libauparse exporting clear_config() Laurent Bigonville
2014-04-10 11:25 ` Steve Grubb
2014-04-11  6:54   ` Laurent Bigonville
2014-04-11 13:42     ` Steve Grubb
2014-04-12 12:46       ` Laurent Bigonville
2014-04-14 12:06         ` Steve Grubb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1966211.j87hqI7kLn@x2 \
    --to=sgrubb@redhat.com \
    --cc=bigon@debian.org \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox