From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Grubb Subject: Re: [RFC PATCH ghak89 V1] audit: rename FILTER_TYPE to FILTER_EXCL Date: Fri, 01 Jun 2018 12:55:51 -0400 Message-ID: <1985834.S9pmFcWHMy@x2> References: <3cc638761823cf16ea71f1c58165832f4b469864.1527798085.git.rgb@redhat.com> <2606099.eSVsdMVj4x@x2> <20180531222120.dixozx3rselct7ot@madcap2.tricolour.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180531222120.dixozx3rselct7ot@madcap2.tricolour.ca> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Richard Guy Briggs Cc: Linux-Audit Mailing List List-Id: linux-audit@redhat.com On Thursday, May 31, 2018 6:21:20 PM EDT Richard Guy Briggs wrote: > On 2018-05-31 17:29, Steve Grubb wrote: > > On Thursday, May 31, 2018 4:23:09 PM EDT Richard Guy Briggs wrote: > > > The AUDIT_FILTER_TYPE name is vague and misleading due to not > > > describing > > > where or when the filter is applied and obsolete due to its available > > > filter fields having been expanded. > > > > > > Userspace has already renamed it from AUDIT_FILTER_TYPE to > > > AUDIT_FILTER_EXCLUDE without checking if it already exists. > > > > Historically speaking, this is not why it is the way it is. But I think > > it > > doesn't mean that you cannot do something like this: > > > > #define AUDIT_FILTER_EXCLUDE AUDIT_FILTER_TYPE > > I was originally hoping to do that, but that then causes a build error > on any previous version of audit userspace. I cannot reproduce this. What error did you get? What version of gcc? Thanks, -Steve