From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Grubb <sgrubb@redhat.com>
Subject: Re: moving audit_free() up into do_exit()
Date: Fri, 31 Mar 2006 15:40:30 -0500
Message-ID: <200603311540.30301.sgrubb@redhat.com>
References: <20060329220358.GN1727@devserv.devel.redhat.com>
	<20060330085453.GP1727@devserv.devel.redhat.com>
	<20060330085638.GQ1727@devserv.devel.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <20060330085638.GQ1727@devserv.devel.redhat.com>
Content-Disposition: inline
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Alexander Viro <aviro@redhat.com>
Cc: akpm@osdl.org, linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On Thursday 30 March 2006 03:56, Alexander Viro wrote:
> On Thu, Mar 30, 2006 at 03:54:53AM -0500, Alexander Viro wrote:
> > OK, preliminary patches attached; the first one is minimal "take care of
>
> Gah...  Attached to this followup; my apologies.

In audit-exit.patch

@@ -607,12 +605,12 @@ static void audit_log_exit(struct audit_
 		  context->gid,
 		  context->euid, context->suid, context->fsuid,
 		  context->egid, context->sgid, context->fsgid, tty);
-	audit_log_task_info(ab, gfp_mask);
+	audit_log_task_info(ab);
 	audit_log_end(ab);
 
 	for (aux = context->aux; aux; aux = aux->next) {
 
-		ab = audit_log_start(context, gfp_mask, aux->type);
+		ab = audit_log_start(context, GFP_KERNEL, aux->type);
 		if (!ab)
 			continue; /* audit_panic has been called */
 
It doesn't compile....it needs:
+	audit_log_task_info(ab, tsk);


Also, piece in kernel/exit.c complains of implicit declaration of 
'audit_free'.

-Steve