From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amy Griffis Subject: Re: [PATCH] [AUDIT] auditfilter.c cleanup/const-ification Date: Tue, 4 Apr 2006 10:37:44 -0400 Message-ID: <20060404143744.GA15978@zk3.dec.com> References: <20060403125128.GG3157@gaz.sfgoth.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com (mx1.redhat.com [172.16.48.31]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id k34EcAAx005108 for ; Tue, 4 Apr 2006 10:38:10 -0400 Received: from palrel10.hp.com (palrel10.hp.com [156.153.255.245]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k34Ec8Ju014507 for ; Tue, 4 Apr 2006 10:38:08 -0400 Content-Disposition: inline In-Reply-To: <20060403125128.GG3157@gaz.sfgoth.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Mitchell Blank Jr Cc: linux-audit@redhat.com, dwmw2@infradead.org List-Id: linux-audit@redhat.com Mitchell Blank Jr wrote: [Mon Apr 03 2006, 08:51:28AM EDT] > While I was looking at auditfilter.c I did some other minor cleanup > > * const-ified pointers where possible > > * both audit_data_to_entry() and audit_krule_to_data() had an unused > variable called "void *bufp" which I removed A patch in -mm is using 'bufp', so it might not be worthwhile to remove at this point. Thanks, Amy