From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mitchell Blank Jr Subject: Re: [PATCH] [AUDIT] auditfilter.c cleanup/const-ification Date: Wed, 5 Apr 2006 04:41:52 -0700 Message-ID: <20060405114152.GC98094@gaz.sfgoth.com> References: <20060403125128.GG3157@gaz.sfgoth.com> <20060404143744.GA15978@zk3.dec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id k35BbfLI028725 for ; Wed, 5 Apr 2006 07:37:41 -0400 Received: from gaz.sfgoth.com (gaz.sfgoth.com [69.36.241.230]) by mx3.redhat.com (8.13.1/8.13.1) with ESMTP id k35BbY9B018157 for ; Wed, 5 Apr 2006 07:37:35 -0400 Content-Disposition: inline In-Reply-To: <20060404143744.GA15978@zk3.dec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Amy Griffis Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com Amy Griffis wrote: > Mitchell Blank Jr wrote: [Mon Apr 03 2006, 08:51:28AM EDT] > > While I was looking at auditfilter.c I did some other minor cleanup > [...] > > * both audit_data_to_entry() and audit_krule_to_data() had an unused > > variable called "void *bufp" which I removed > > A patch in -mm is using 'bufp', so it might not be worthwhile to > remove at this point. Do you have any info on this patch? The latest -mm (17-rc1-mm1) doesn't touch auditfilter.c at all. -Mitch