From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Serge E. Hallyn" <serue@us.ibm.com>
Subject: Re: [PATCH 2/2] updated filesystem auditing patches for lspp test
	kernel
Date: Mon, 10 Apr 2006 12:56:26 -0500
Message-ID: <20060410175626.GA27252@sergelap.austin.ibm.com>
References: <20060407205556.GA29979@zk3.dec.com>
	<20060407205653.GB29979@zk3.dec.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-audit-bounces@redhat.com>
Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32])
	by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id
	k3AHueXf004053
	for <linux-audit@redhat.com>; Mon, 10 Apr 2006 13:56:40 -0400
Received: from e32.co.us.ibm.com (e32.co.us.ibm.com [32.97.110.150])
	by mx3.redhat.com (8.13.1/8.13.1) with ESMTP id k3AHuYpg006734
	for <linux-audit@redhat.com>; Mon, 10 Apr 2006 13:56:34 -0400
Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com
	[9.17.195.11])
	by e32.co.us.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id
	k3AHuTEI017478
	for <linux-audit@redhat.com>; Mon, 10 Apr 2006 13:56:29 -0400
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.8) with ESMTP id
	k3AHr1ne234684
	for <linux-audit@redhat.com>; Mon, 10 Apr 2006 11:53:01 -0600
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id
	k3AHuSse004498
	for <linux-audit@redhat.com>; Mon, 10 Apr 2006 11:56:28 -0600
Content-Disposition: inline
In-Reply-To: <20060407205653.GB29979@zk3.dec.com>
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: linux-audit@redhat.com, amy.griffis@hp.com
List-Id: linux-audit@redhat.com

Hard to give this a meaningful review - particularly the first patch,
a large part of which seemed to be moving functionality from one file to
another.  But slowly reading along, at least this smells like an error:

Quoting Amy Griffis (amy.griffis@hp.com):
> +/* Initialize a watch entry. */
> +static inline struct audit_watch *audit_init_watch(char *path)
> +{
> +	struct audit_watch *watch;
> +
> +	watch = kzalloc(sizeof(*watch), GFP_KERNEL);
> +	if (unlikely(!watch))
> +		return ERR_PTR(-ENOMEM);
...
> +	watch = audit_init_watch(path);
> +	if (unlikely(IS_ERR(watch)))
> +		return PTR_ERR(watch);

Ok, but

> +	new = audit_init_watch(path);
> +	if (unlikely(!new)) {
> +		kfree(path);
> +		return ERR_PTR(-ENOMEM);
> +	}

not ok

-serge