Linux-audit Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Jones <tonyj@suse.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-audit@redhat.com, dwmw2@infradead.org
Subject: Re: [RFC: 2.6 patch] kernel/audit.c: remove unused exports
Date: Thu, 20 Apr 2006 14:25:19 -0700	[thread overview]
Message-ID: <20060420212519.GA4941@suse.de> (raw)
In-Reply-To: <20060420210521.GX25047@stusta.de>

On Thu, Apr 20, 2006 at 11:05:21PM +0200, Adrian Bunk wrote:
> This patch removes the following unused EXPORT_SYMBOL's:
> - audit_log_start
> - audit_log_end
> - audit_log_format
> - audit_log
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> --- linux-2.6.17-rc1-mm3-full/kernel/audit.c.old	2006-04-20 22:38:17.000000000 +0200
> +++ linux-2.6.17-rc1-mm3-full/kernel/audit.c	2006-04-20 22:40:03.000000000 +0200
> @@ -1092,7 +1092,3 @@
>  	}
>  }
>  
> -EXPORT_SYMBOL(audit_log_start);
> -EXPORT_SYMBOL(audit_log_end);
> -EXPORT_SYMBOL(audit_log_format);
> -EXPORT_SYMBOL(audit_log);

It would seem useful to allow out of tree modules (even if they never have
a goal of submitting to become intree) to log audit data. No?  A reason to
prevent it seems utterly lost on me.

Tony

  reply	other threads:[~2006-04-20 21:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-20 21:05 [RFC: 2.6 patch] kernel/audit.c: remove unused exports Adrian Bunk
2006-04-20 21:25 ` Tony Jones [this message]
2006-04-21  9:27   ` Adrian Bunk
2006-04-21 13:10     ` Steve Grubb
2006-04-21 13:12       ` David Woodhouse
2006-04-21 17:24     ` Tony Jones
2006-04-21 18:12       ` Adrian Bunk
2006-04-20 22:44 ` Steve Grubb
2006-04-20 22:48   ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060420212519.GA4941@suse.de \
    --to=tonyj@suse.de \
    --cc=bunk@stusta.de \
    --cc=dwmw2@infradead.org \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox