From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tony Jones <tonyj@suse.de>
Subject: Re: [RFC: 2.6 patch] kernel/audit.c: remove unused exports
Date: Thu, 20 Apr 2006 14:25:19 -0700
Message-ID: <20060420212519.GA4941@suse.de>
References: <20060420210521.GX25047@stusta.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-audit-bounces@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [172.16.48.31])
	by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id
	k3KLU0tE016567
	for <linux-audit@redhat.com>; Thu, 20 Apr 2006 17:30:00 -0400
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
	by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id
	k3KLTw4W030103
	for <linux-audit@redhat.com>; Thu, 20 Apr 2006 17:29:59 -0400
Content-Disposition: inline
In-Reply-To: <20060420210521.GX25047@stusta.de>
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-audit@redhat.com, dwmw2@infradead.org
List-Id: linux-audit@redhat.com

On Thu, Apr 20, 2006 at 11:05:21PM +0200, Adrian Bunk wrote:
> This patch removes the following unused EXPORT_SYMBOL's:
> - audit_log_start
> - audit_log_end
> - audit_log_format
> - audit_log
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> --- linux-2.6.17-rc1-mm3-full/kernel/audit.c.old	2006-04-20 22:38:17.000000000 +0200
> +++ linux-2.6.17-rc1-mm3-full/kernel/audit.c	2006-04-20 22:40:03.000000000 +0200
> @@ -1092,7 +1092,3 @@
>  	}
>  }
>  
> -EXPORT_SYMBOL(audit_log_start);
> -EXPORT_SYMBOL(audit_log_end);
> -EXPORT_SYMBOL(audit_log_format);
> -EXPORT_SYMBOL(audit_log);

It would seem useful to allow out of tree modules (even if they never have
a goal of submitting to become intree) to log audit data. No?  A reason to
prevent it seems utterly lost on me.

Tony