From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: Re: [RFC: 2.6 patch] kernel/audit.c: remove unused exports Date: Fri, 21 Apr 2006 11:27:55 +0200 Message-ID: <20060421092755.GB19754@stusta.de> References: <20060420210521.GX25047@stusta.de> <20060420212519.GA4941@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id k3L9SA3h004362 for ; Fri, 21 Apr 2006 05:28:10 -0400 Received: from mailout.stusta.mhn.de (mailout.stusta.mhn.de [141.84.69.5]) by mx3.redhat.com (8.13.1/8.13.1) with SMTP id k3L9S1ns014998 for ; Fri, 21 Apr 2006 05:28:02 -0400 Content-Disposition: inline In-Reply-To: <20060420212519.GA4941@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Tony Jones Cc: linux-audit@redhat.com, dwmw2@infradead.org List-Id: linux-audit@redhat.com On Thu, Apr 20, 2006 at 02:25:19PM -0700, Tony Jones wrote: > On Thu, Apr 20, 2006 at 11:05:21PM +0200, Adrian Bunk wrote: > > This patch removes the following unused EXPORT_SYMBOL's: > > - audit_log_start > > - audit_log_end > > - audit_log_format > > - audit_log > > > > Signed-off-by: Adrian Bunk > > > > --- linux-2.6.17-rc1-mm3-full/kernel/audit.c.old 2006-04-20 22:38:17.000000000 +0200 > > +++ linux-2.6.17-rc1-mm3-full/kernel/audit.c 2006-04-20 22:40:03.000000000 +0200 > > @@ -1092,7 +1092,3 @@ > > } > > } > > > > -EXPORT_SYMBOL(audit_log_start); > > -EXPORT_SYMBOL(audit_log_end); > > -EXPORT_SYMBOL(audit_log_format); > > -EXPORT_SYMBOL(audit_log); > > It would seem useful to allow out of tree modules (even if they never have > a goal of submitting to become intree) to log audit data. No? A reason to > prevent it seems utterly lost on me. Out of tree modules without the goal of being submitted are not a good idea. AppArmor/LSM is a good example what can happen if people don't submit their external modules for inclusion in the kernel. > Tony cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed