From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Jones Subject: Re: [RFC: 2.6 patch] kernel/audit.c: remove unused exports Date: Fri, 21 Apr 2006 10:24:10 -0700 Message-ID: <20060421172410.GB32038@suse.de> References: <20060420210521.GX25047@stusta.de> <20060420212519.GA4941@suse.de> <20060421092755.GB19754@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx3.redhat.com (mx3.redhat.com [172.16.48.32]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id k3LHSiBw023091 for ; Fri, 21 Apr 2006 13:28:44 -0400 Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by mx3.redhat.com (8.13.1/8.13.1) with ESMTP id k3LHSbKL015833 for ; Fri, 21 Apr 2006 13:28:38 -0400 Content-Disposition: inline In-Reply-To: <20060421092755.GB19754@stusta.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Adrian Bunk Cc: linux-audit@redhat.com, dwmw2@infradead.org List-Id: linux-audit@redhat.com On Fri, Apr 21, 2006 at 11:27:55AM +0200, Adrian Bunk wrote: > > > -EXPORT_SYMBOL(audit_log_start); > > > -EXPORT_SYMBOL(audit_log_end); > > > -EXPORT_SYMBOL(audit_log_format); > > > -EXPORT_SYMBOL(audit_log); > > > > It would seem useful to allow out of tree modules (even if they never have > > a goal of submitting to become intree) to log audit data. No? A reason to > > prevent it seems utterly lost on me. > > Out of tree modules without the goal of being submitted are not a good > idea. What a stupid comment (in general and expecially given the nature of the audit subsystem ). Sorry. Also, there are probably at present no intree users of audit other than compiled built-in. I'm guessing by your patch you believe built-in to be the only valid configuration mode for said users :-) EXPORT_SYMBOL_GPL, sure. > AppArmor/LSM is a good example what can happen if people don't submit > their external modules for inclusion in the kernel. LOL. Thanks for the daily laugh. Tony