Re: [RFC: 2.6 patch] kernel/audit.c: remove unused exports

[Adrian Bunk <bunk@stusta.de>]

On Fri, Apr 21, 2006 at 10:24:10AM -0700, Tony Jones wrote:
> On Fri, Apr 21, 2006 at 11:27:55AM +0200, Adrian Bunk wrote:
> > > > -EXPORT_SYMBOL(audit_log_start);
> > > > -EXPORT_SYMBOL(audit_log_end);
> > > > -EXPORT_SYMBOL(audit_log_format);
> > > > -EXPORT_SYMBOL(audit_log);
> > > 
> > > It would seem useful to allow out of tree modules (even if they never have
> > > a goal of submitting to become intree) to log audit data. No?  A reason to
> > > prevent it seems utterly lost on me.
> > 
> > Out of tree modules without the goal of being submitted are not a good 
> > idea.
> 
> What a stupid comment (in general and expecially given the nature of the audit 
> subsystem ). Sorry. 
> 
> Also, there are probably at present no intree users of audit other than 
> compiled built-in. I'm guessing by your patch you believe built-in to be the 
> only valid configuration mode for said users :-)
> 
> EXPORT_SYMBOL_GPL, sure.
>...

I don't have a fixed opinion about whether future in-kernel users of the 
audit subsystem could be modules.

Currently there are none, and if modular users get added at some point 
in the future re-exporting them will be trivial.

Until then, removing the exports simply makes the kernel image a bit 
smaller.

> Tony

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed