From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrian Bunk Subject: Re: [RFC: 2.6 patch] kernel/audit.c: remove unused exports Date: Fri, 21 Apr 2006 20:12:43 +0200 Message-ID: <20060421181243.GH19754@stusta.de> References: <20060420210521.GX25047@stusta.de> <20060420212519.GA4941@suse.de> <20060421092755.GB19754@stusta.de> <20060421172410.GB32038@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mx1.redhat.com (mx1.redhat.com [172.16.48.31]) by int-mx1.corp.redhat.com (8.12.11.20060308/8.11.6) with ESMTP id k3LICo9M032722 for ; Fri, 21 Apr 2006 14:12:50 -0400 Received: from mailout.stusta.mhn.de (emailhub.stusta.mhn.de [141.84.69.5]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with SMTP id k3LICmHA012443 for ; Fri, 21 Apr 2006 14:12:48 -0400 Content-Disposition: inline In-Reply-To: <20060421172410.GB32038@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Tony Jones Cc: linux-audit@redhat.com, dwmw2@infradead.org List-Id: linux-audit@redhat.com On Fri, Apr 21, 2006 at 10:24:10AM -0700, Tony Jones wrote: > On Fri, Apr 21, 2006 at 11:27:55AM +0200, Adrian Bunk wrote: > > > > -EXPORT_SYMBOL(audit_log_start); > > > > -EXPORT_SYMBOL(audit_log_end); > > > > -EXPORT_SYMBOL(audit_log_format); > > > > -EXPORT_SYMBOL(audit_log); > > > > > > It would seem useful to allow out of tree modules (even if they never have > > > a goal of submitting to become intree) to log audit data. No? A reason to > > > prevent it seems utterly lost on me. > > > > Out of tree modules without the goal of being submitted are not a good > > idea. > > What a stupid comment (in general and expecially given the nature of the audit > subsystem ). Sorry. > > Also, there are probably at present no intree users of audit other than > compiled built-in. I'm guessing by your patch you believe built-in to be the > only valid configuration mode for said users :-) > > EXPORT_SYMBOL_GPL, sure. >... I don't have a fixed opinion about whether future in-kernel users of the audit subsystem could be modules. Currently there are none, and if modular users get added at some point in the future re-exporting them will be trivial. Until then, removing the exports simply makes the kernel image a bit smaller. > Tony cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed