Linux-audit Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Amy Griffis <amy.griffis@hp.com>
To: linux-audit@redhat.com
Subject: [PATCH git] fix oops in fs audit patch
Date: Thu, 1 Jun 2006 10:50:03 -0400	[thread overview]
Message-ID: <20060601145002.GA1684@zk3.dec.com> (raw)

Fix bad list management in audit_inotify_unregister().

Al, please fold in with latest filesystem auditing patch
46c438b705c31284f31c64a0d18bf3bd6c62cde3.

Signed-off-by: Amy Griffis <amy.griffis@hp.com>

diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index f993842..7609694 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -822,9 +822,10 @@ static inline void audit_remove_parent_w
  * Generates an IN_IGNORED event. */
 static void audit_inotify_unregister(struct list_head *in_list)
 {
-	struct audit_parent *p;
+	struct audit_parent *p, *n;
 
-	list_for_each_entry(p, in_list, ilist) {
+	list_for_each_entry_safe(p, n, in_list, ilist) {
+		list_del(&p->ilist);
 		inotify_rm_watch(audit_ih, &p->wdata);
 		/* the put matching the get in audit_do_del_rule() */
 		put_inotify_watch(&p->wdata);

                 reply	other threads:[~2006-06-01 14:50 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060601145002.GA1684@zk3.dec.com \
    --to=amy.griffis@hp.com \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox