From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Jackson Subject: Re: [RFC][PATCH 05/10] Task watchers v2 Register cpuset task watcher Date: Thu, 28 Sep 2006 19:31:38 -0700 Message-ID: <20060928193138.963c510a.pj@sgi.com> References: <20060929020232.756637000@us.ibm.com> <20060929021300.851205000@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060929021300.851205000@us.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: lse-tech-bounces@lists.sourceforge.net Errors-To: lse-tech-bounces@lists.sourceforge.net To: Matt Helsley Cc: sekharan@us.ibm.com, jtk@us.ibm.com, jes@sgi.com, linux-kernel@vger.kernel.org, linux-audit@redhat.com, viro@zeniv.linux.org.uk, lse-tech@lists.sourceforge.net, sgrubb@redhat.com, hch@lst.de List-Id: linux-audit@redhat.com Matt wrote: > - cpuset_fork(p); > #ifdef CONFIG_NUMA > p->mempolicy = mpol_copy(p->mempolicy); > if (IS_ERR(p->mempolicy)) { > retval = PTR_ERR(p->mempolicy); > p->mempolicy = NULL; > - goto bad_fork_cleanup_cpuset; > + goto bad_fork_cleanup_delays_binfmt; > } > mpol_fix_fork_child_flag(p); > #endif > #ifdef CONFIG_TRACE_IRQFLAGS > p->irq_events = 0; > @@ -1280,13 +1278,11 @@ bad_fork_cleanup_files: > bad_fork_cleanup_security: > security_task_free(p); > bad_fork_cleanup_policy: > #ifdef CONFIG_NUMA > mpol_free(p->mempolicy); > -bad_fork_cleanup_cpuset: > #endif > - cpuset_exit(p); > bad_fork_cleanup_delays_binfmt: The above code, before your change, had the affect that if mpol_copy() failed, then the cpusets that were just setup by the cpuset_fork() call were undone by a cpuset_exit() call. >>From what I can tell, after your change, this is no longer done, and a failed mpol_copy will leave cpusets in an incorrect state. Am I missing something? -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson 1.925.600.0401 ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV