[RFC][PATCH 08/10] Task watchers v2 Register lockdep task watcher

Matt Helsley
2006-09-29T02:02:40Z

[-- Attachment #1: task-watchers-register-lockdep --]
[-- Type: text/plain, Size: 2002 bytes --]

Register a task watcher for lockdep instead of hooking into copy_process().

Signed-off-by: Matt Helsley <matthltc@us.ibm.com>
---
kernel/fork.c | 5 -----
kernel/lockdep.c | 9 +++++++++
2 files changed, 9 insertions(+), 5 deletions(-)

Index: linux-2.6.18-mm1/kernel/fork.c
===================================================================
--- linux-2.6.18-mm1.orig/kernel/fork.c
+++ linux-2.6.18-mm1/kernel/fork.c
@@ -1058,15 +1058,10 @@ static struct task_struct *copy_process(
p->tgid = current->tgid;

retval = notify_task_watchers(WATCH_TASK_INIT, clone_flags, p);
if (retval < 0)
goto bad_fork_cleanup_delays_binfmt;
-#ifdef CONFIG_LOCKDEP
- p->lockdep_depth = 0; /* no locks held yet */
- p->curr_chain_key = 0;
- p->lockdep_recursion = 0;
-#endif

rt_mutex_init_task(p);

#ifdef CONFIG_DEBUG_MUTEXES
p->blocked_on = NULL; /* not blocked yet */
Index: linux-2.6.18-mm1/kernel/lockdep.c
===================================================================
--- linux-2.6.18-mm1.orig/kernel/lockdep.c
+++ linux-2.6.18-mm1/kernel/lockdep.c
@@ -2555,10 +2555,19 @@ void __init lockdep_init(void)
INIT_LIST_HEAD(chainhash_table + i);

lockdep_initialized = 1;
}

+static int init_task_lockdep(unsigned long clone_flags, struct task_struct *p)
+{
+ p->lockdep_depth = 0; /* no locks held yet */
+ p->curr_chain_key = 0;
+ p->lockdep_recursion = 0;
+ return 0;
+}
+task_watcher_func(init, init_task_lockdep);
+
void __init lockdep_info(void)
{
printk("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");

printk("... MAX_LOCKDEP_SUBCLASSES: %lu\n", MAX_LOCKDEP_SUBCLASSES);