From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Jackson Subject: Re: [PATCH 0/9] Task Watchers v2: Introduction Date: Fri, 3 Nov 2006 00:57:47 -0800 Message-ID: <20061103005747.60bfbd87.pj@sgi.com> References: <20061103042257.274316000@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20061103042257.274316000@us.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: lse-tech-bounces@lists.sourceforge.net Errors-To: lse-tech-bounces@lists.sourceforge.net To: Matt Helsley Cc: akpm@osdl.org, sekharan@us.ibm.com, jes@sgi.com, linux-kernel@vger.kernel.org, linux-audit@redhat.com, viro@zeniv.linux.org.uk, lse-tech@lists.sourceforge.net, sgrubb@redhat.com, hch@lst.de List-Id: linux-audit@redhat.com Matt wrote: > Task watchers is primarily useful to existing kernel code as a means of making > the code in fork and exit more readable. I don't get it. The benchmark data isn't explained in plain English what it means, that I could find, so I am just guessing. But looking at the last (17500) column of the fork results, after applying patch 1/9, I see a number of 18565, and looking at that same column in patch 9/9, I see a number of 18142. I guess that means a drop of (18565 - 18142 / 18565) == 2% in the fork rate, to make the code "more readable". And I'm not even sure it makes it more readable. Looks to me like another layer of apparatus, which is one more thing to figure out before a reader understands what is going on. I'd gladly put in a few long days to improve the fork rate 2%, and I am grateful to those who have already done so - whoever they are. Somewhere I must have missed the memo explaining why this patch is a good idea - sorry. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson 1.925.600.0401 ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642