From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Grubb <sgrubb@redhat.com>
Subject: Re: fixed ipsec audit patch
Date: Mon, 20 Nov 2006 14:11:11 -0500
Message-ID: <200611201411.11996.sgrubb@redhat.com>
References: <200611201726.kAKHQXer022196@faith.austin.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <200611201726.kAKHQXer022196@faith.austin.ibm.com>
Content-Disposition: inline
List-Unsubscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Joy Latten <latten@austin.ibm.com>
Cc: linux-audit@redhat.com
List-Id: linux-audit@redhat.com

On Monday 20 November 2006 12:26, Joy Latten wrote:
> Here is the fixed ipsec patch.
> Let me know if all is ok.

I think this looks OK with the exception of 1 thing. (I missed it on your last 
patch.)

>+        audit_log_format(audit_buf, " sec_alg=%u sec_doi=%u ctx=%s",

I thought we were not going to use ctx since that's too generic. The name  
should either be subj or obj based depending on what it is.

-Steve